From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989)
Date: Tue, 04 Oct 2011 11:16:00 -0000 [thread overview]
Message-ID: <20111004111537.GB22731@calimero.vinschen.de> (raw)
In-Reply-To: <E1RB2QN-0003Qv-81@fencepost.gnu.org>
On Oct 4 06:40, Eli Zaretskii wrote:
> To comment on the part of what you say that I do understand: using
> SetEnvironmentVariable in this case is not TRT, because that changes
> the environment of GDB itself. By contrast, "set environment" and
> "unset environment" commands are supposed to affect only the
> environment of the inferior, without any effect on GDB itself. That
> is why I didn't use SetEnvironmentVariable in my patch.
Duh, you're right. Maybe my proposal to create the UNICODE environment
in a static function and use that in both code paths as in
http://sourceware.org/ml/gdb-patches/2011-10/msg00071.html
is acceptable?
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
prev parent reply other threads:[~2011-10-04 11:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 13:24 [RFA] Environment variables passed to inferior by MinGW build (PR 10989) Eli Zaretskii
2011-09-11 22:03 ` asmwarrior
2011-09-19 8:04 ` Eli Zaretskii
2011-09-25 23:56 ` Eli Zaretskii
2011-09-26 5:22 ` Stan Shebs
2011-09-26 17:22 ` Joel Brobecker
2011-09-26 18:23 ` Eli Zaretskii
2011-09-28 9:39 ` Eli Zaretskii
2011-10-03 18:18 ` Tom Tromey
2011-10-03 18:25 ` Eli Zaretskii
2011-10-04 7:54 ` Corinna Vinschen
2011-10-04 9:29 ` Eli Zaretskii
2011-10-04 11:13 ` Corinna Vinschen
2011-10-04 9:56 ` [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989) Pierre Muller
2011-10-04 10:40 ` Eli Zaretskii
2011-10-04 11:16 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004111537.GB22731@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox