From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989)
Date: Mon, 26 Sep 2011 17:22:00 -0000 [thread overview]
Message-ID: <20110926171511.GJ17681@adacore.com> (raw)
In-Reply-To: <4E7FBF9E.20000@earthlink.net>
> >Ping! Ping! (2 weeks)
>
> Seems uncontroversial to me (the previous discussion being about
> entirely different issues). Let's put it in!
And I think that 2 weeks without comment from the area maintainer
is reasonable delay for a Global Maintainer to approve or
self-approve... If it turns out the area maintainer was away
during that time, and finds some problems, we can always fix or
revert.
> >>>2011-09-11 Eli Zaretskii<eliz@gnu.org>
> >>>
> >>> * windows-nat.c (env_sort) [!__CYGWIN__]: Function restored from
> >>> before the change on 2006-12-09.
> >>> (windows_create_inferior) [!__CYGWIN__]: Restore code that
> >>> generates the environment block for CreateProcessA, modulo the
> >>> Cygwin-specific parts that are not needed here.
Just a few comments:
> >>>+#ifndef __CYGWIN__
> >>>+/* Function called by qsort to sort environment strings. */
> >>>+static int
Empty line after the function description (and before the declaration).
> >>>+env_sort (const void *a, const void *b)
Can we rename it to something like `env_cmp'. The use of `sort' makes
me think that the contents of `a' and `b' are going to be swapped if
b < a...
(this is a bit of a nitpick, so feel free to ignore)
> >>>+ for (envlen = 0, i = 0; in_env[i]&& *in_env[i]; i++)
^^^ formatting of the `&&' ?
--
Joel
next prev parent reply other threads:[~2011-09-26 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 13:24 Eli Zaretskii
2011-09-11 22:03 ` asmwarrior
2011-09-19 8:04 ` Eli Zaretskii
2011-09-25 23:56 ` Eli Zaretskii
2011-09-26 5:22 ` Stan Shebs
2011-09-26 17:22 ` Joel Brobecker [this message]
2011-09-26 18:23 ` Eli Zaretskii
2011-09-28 9:39 ` Eli Zaretskii
2011-10-03 18:18 ` Tom Tromey
2011-10-03 18:25 ` Eli Zaretskii
2011-10-04 7:54 ` Corinna Vinschen
2011-10-04 9:29 ` Eli Zaretskii
2011-10-04 11:13 ` Corinna Vinschen
2011-10-04 9:56 ` [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989) Pierre Muller
2011-10-04 10:40 ` Eli Zaretskii
2011-10-04 11:16 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926171511.GJ17681@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox