From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13459 invoked by alias); 26 Sep 2011 17:15:37 -0000 Received: (qmail 13424 invoked by uid 22791); 26 Sep 2011 17:15:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Sep 2011 17:15:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 98D6F2BB1F1; Mon, 26 Sep 2011 13:15:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6A-Ha6sHjNvo; Mon, 26 Sep 2011 13:15:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6873A2BB0EB; Mon, 26 Sep 2011 13:15:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E3615145615; Mon, 26 Sep 2011 13:15:11 -0400 (EDT) Date: Mon, 26 Sep 2011 17:22:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989) Message-ID: <20110926171511.GJ17681@adacore.com> References: <4E7FBF9E.20000@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E7FBF9E.20000@earthlink.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00447.txt.bz2 > >Ping! Ping! (2 weeks) > > Seems uncontroversial to me (the previous discussion being about > entirely different issues). Let's put it in! And I think that 2 weeks without comment from the area maintainer is reasonable delay for a Global Maintainer to approve or self-approve... If it turns out the area maintainer was away during that time, and finds some problems, we can always fix or revert. > >>>2011-09-11 Eli Zaretskii > >>> > >>> * windows-nat.c (env_sort) [!__CYGWIN__]: Function restored from > >>> before the change on 2006-12-09. > >>> (windows_create_inferior) [!__CYGWIN__]: Restore code that > >>> generates the environment block for CreateProcessA, modulo the > >>> Cygwin-specific parts that are not needed here. Just a few comments: > >>>+#ifndef __CYGWIN__ > >>>+/* Function called by qsort to sort environment strings. */ > >>>+static int Empty line after the function description (and before the declaration). > >>>+env_sort (const void *a, const void *b) Can we rename it to something like `env_cmp'. The use of `sort' makes me think that the contents of `a' and `b' are going to be swapped if b < a... (this is a bit of a nitpick, so feel free to ignore) > >>>+ for (envlen = 0, i = 0; in_env[i]&& *in_env[i]; i++) ^^^ formatting of the `&&' ? -- Joel