Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Environment variables passed to inferior by MinGW build   (PR 10989)
Date: Tue, 04 Oct 2011 07:54:00 -0000	[thread overview]
Message-ID: <20111004075325.GB13895@calimero.vinschen.de> (raw)
In-Reply-To: <20110926171511.GJ17681@adacore.com>

On Sep 26 10:15, Joel Brobecker wrote:
> > >Ping!  Ping!  (2 weeks)
> > 
> > Seems uncontroversial to me (the previous discussion being about
> > entirely different issues).  Let's put it in!
> 
> And I think that 2 weeks without comment from the area maintainer
> is reasonable delay for a Global Maintainer to approve or
> self-approve... If it turns out the area maintainer was away
> during that time, and finds some problems, we can always fix or
> revert.

I was on vacation and I'm also not the area maintainer for windows-nat.c.
I commented to http://sourceware.org/ml/gdb-patches/2011-04/msg00347.html
because what Pierre was doing looked wrong to me.

Eli's patch is ok, IMHO, but it's a pity that Pierre never followed up
to http://sourceware.org/ml/gdb-patches/2011-04/msg00351.html since that
means that now setting environment variables works in Mingw, but not in
Cygwin.  So, as far as I can see, PR #10989 should not have been closed
yet.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


  parent reply	other threads:[~2011-10-04  7:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-11 13:24 Eli Zaretskii
2011-09-11 22:03 ` asmwarrior
2011-09-19  8:04 ` Eli Zaretskii
2011-09-25 23:56   ` Eli Zaretskii
2011-09-26  5:22     ` Stan Shebs
2011-09-26 17:22       ` Joel Brobecker
2011-09-26 18:23         ` Eli Zaretskii
2011-09-28  9:39           ` Eli Zaretskii
2011-10-03 18:18             ` Tom Tromey
2011-10-03 18:25               ` Eli Zaretskii
2011-10-04  7:54         ` Corinna Vinschen [this message]
2011-10-04  9:29           ` Eli Zaretskii
2011-10-04 11:13             ` Corinna Vinschen
2011-10-04  9:56           ` [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989) Pierre Muller
2011-10-04 10:40             ` Eli Zaretskii
2011-10-04 11:16               ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111004075325.GB13895@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox