From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3079 invoked by alias); 4 Oct 2011 07:54:07 -0000 Received: (qmail 3038 invoked by uid 22791); 4 Oct 2011 07:53:47 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Tue, 04 Oct 2011 07:53:28 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 1511D2C00DB; Tue, 4 Oct 2011 09:53:26 +0200 (CEST) Date: Tue, 04 Oct 2011 07:54:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989) Message-ID: <20111004075325.GB13895@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <4E7FBF9E.20000@earthlink.net> <20110926171511.GJ17681@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20110926171511.GJ17681@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00063.txt.bz2 On Sep 26 10:15, Joel Brobecker wrote: > > >Ping! Ping! (2 weeks) > > > > Seems uncontroversial to me (the previous discussion being about > > entirely different issues). Let's put it in! > > And I think that 2 weeks without comment from the area maintainer > is reasonable delay for a Global Maintainer to approve or > self-approve... If it turns out the area maintainer was away > during that time, and finds some problems, we can always fix or > revert. I was on vacation and I'm also not the area maintainer for windows-nat.c. I commented to http://sourceware.org/ml/gdb-patches/2011-04/msg00347.html because what Pierre was doing looked wrong to me. Eli's patch is ok, IMHO, but it's a pity that Pierre never followed up to http://sourceware.org/ml/gdb-patches/2011-04/msg00351.html since that means that now setting environment variables works in Mingw, but not in Cygwin. So, as far as I can see, PR #10989 should not have been closed yet. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat