From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4803 invoked by alias); 4 Oct 2011 11:16:20 -0000 Received: (qmail 4716 invoked by uid 22791); 4 Oct 2011 11:15:53 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Tue, 04 Oct 2011 11:15:40 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 182492C00DB; Tue, 4 Oct 2011 13:15:37 +0200 (CEST) Date: Tue, 04 Oct 2011 11:16:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989) Message-ID: <20111004111537.GB22731@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <4E7FBF9E.20000@earthlink.net> <20110926171511.GJ17681@adacore.com> <20111004075325.GB13895@calimero.vinschen.de> <004801cc827b$e752bfd0$b5f83f70$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00072.txt.bz2 On Oct 4 06:40, Eli Zaretskii wrote: > To comment on the part of what you say that I do understand: using > SetEnvironmentVariable in this case is not TRT, because that changes > the environment of GDB itself. By contrast, "set environment" and > "unset environment" commands are supposed to affect only the > environment of the inferior, without any effect on GDB itself. That > is why I didn't use SetEnvironmentVariable in my patch. Duh, you're right. Maybe my proposal to create the UNICODE environment in a static function and use that in both code paths as in http://sourceware.org/ml/gdb-patches/2011-10/msg00071.html is acceptable? Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat