From: Mike Frysinger <vapier@gentoo.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] gdbserver: add support for FDPIC loadmaps
Date: Thu, 29 Sep 2011 14:35:00 -0000 [thread overview]
Message-ID: <201109291031.46062.vapier@gentoo.org> (raw)
In-Reply-To: <4E843213.8040403@codesourcery.com>
[-- Attachment #1: Type: Text/Plain, Size: 883 bytes --]
On Thursday, September 29, 2011 04:53:39 Yao Qi wrote:
> On 09/29/2011 11:58 AM, Mike Frysinger wrote:
> > --- a/gdb/common/linux-ptrace.h
> > +++ b/gdb/common/linux-ptrace.h
> >
> > +#if (defined __bfin__ || defined __frv__ || defined __sh__) && \
> > + !defined PTRACE_GETFDPIC
> > +#define PTRACE_GETFDPIC 31
> > +#define PTRACE_GETFDPIC_EXEC 0
> > +#define PTRACE_GETFDPIC_INTERP 1
> > +#endif
>
> Do you have some reasons to define these macros in common/? I don't see
> these macros are/will be used in GDB, so maybe, we can move them in
> gdbserver. Files in common/ are to have contents shared between gdb and
> gdbserver.
it isn't out of the realm of possibility to have a native gdb running which
would need these ptrace defines. unlikely, but not impossible. this file
seemed to be the best place for fallback linux ptrace defines.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-09-29 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 4:07 Mike Frysinger
2011-09-29 9:34 ` Yao Qi
2011-09-29 11:23 ` Pedro Alves
2011-09-29 14:35 ` Mike Frysinger [this message]
2011-09-30 1:10 ` Yao Qi
2011-09-29 11:25 ` Pedro Alves
2011-09-30 0:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109291031.46062.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox