From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Yao Qi <yao@codesourcery.com>, Mike Frysinger <vapier@gentoo.org>,
toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] gdbserver: add support for FDPIC loadmaps
Date: Thu, 29 Sep 2011 11:23:00 -0000 [thread overview]
Message-ID: <201109291212.53297.pedro@codesourcery.com> (raw)
In-Reply-To: <4E843213.8040403@codesourcery.com>
On Thursday 29 September 2011 09:53:39, Yao Qi wrote:
> > -#endif
> > +# define LINUX_LOADMAP PT_GETDSBT
> > +# define LINUX_LOADMAP_EXEC PTRACE_GETDSBT_EXEC
> > +# define LINUX_LOADMAP_INTERP PTRACE_GETDSBT_INTERP
> > +# else
>
> The spaces between '#' and 'define' are not needed.
Please leave them in. They're useful to follow the
indentation level.
--
Pedro Alves
next prev parent reply other threads:[~2011-09-29 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 4:07 Mike Frysinger
2011-09-29 9:34 ` Yao Qi
2011-09-29 11:23 ` Pedro Alves [this message]
2011-09-29 14:35 ` Mike Frysinger
2011-09-30 1:10 ` Yao Qi
2011-09-29 11:25 ` Pedro Alves
2011-09-30 0:56 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109291212.53297.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox