From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24871 invoked by alias); 29 Sep 2011 14:32:04 -0000 Received: (qmail 24853 invoked by uid 22791); 29 Sep 2011 14:32:01 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 14:31:47 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 89D7B64230; Thu, 29 Sep 2011 14:31:46 +0000 (UTC) From: Mike Frysinger To: Yao Qi Subject: Re: [PATCH] gdbserver: add support for FDPIC loadmaps Date: Thu, 29 Sep 2011 14:35:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1317268705-29948-1-git-send-email-vapier@gentoo.org> <4E843213.8040403@codesourcery.com> In-Reply-To: <4E843213.8040403@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1909581.LsadIkM7rP"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201109291031.46062.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00543.txt.bz2 --nextPart1909581.LsadIkM7rP Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 874 On Thursday, September 29, 2011 04:53:39 Yao Qi wrote: > On 09/29/2011 11:58 AM, Mike Frysinger wrote: > > --- a/gdb/common/linux-ptrace.h > > +++ b/gdb/common/linux-ptrace.h > >=20 > > +#if (defined __bfin__ || defined __frv__ || defined __sh__) && \ > > + !defined PTRACE_GETFDPIC > > +#define PTRACE_GETFDPIC 31 > > +#define PTRACE_GETFDPIC_EXEC 0 > > +#define PTRACE_GETFDPIC_INTERP 1 > > +#endif >=20 > Do you have some reasons to define these macros in common/? I don't see > these macros are/will be used in GDB, so maybe, we can move them in > gdbserver. Files in common/ are to have contents shared between gdb and > gdbserver. it isn't out of the realm of possibility to have a native gdb running which= =20 would need these ptrace defines. unlikely, but not impossible. this file= =20 seemed to be the best place for fallback linux ptrace defines. -mike --nextPart1909581.LsadIkM7rP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iQIcBAABAgAGBQJOhIFSAAoJEEFjO5/oN/WBMfgQAJ0CNlGbbAIQ1iOzoYuezXyA 4qKrxGYQwGmAE0KVOim6bN9cj8/vMeMBj5bGbcwN796CEek72MOBoM873x8huqhi Gv1Ma3LyYw3C5rm+6B96AAPuXv2xQiNwa8BaPMbl0J0JuCx6SgGxtvLNz8gdXmy0 XjlFL/XZcQcgLYdPzCQXjCL69QSHW+m0uFHJPESM2lO7m9bRG8r4gb0pgn9JKuts NpBKZ1lKQ7qHI4O7j4ayc5jrYY3wTwUIfJIYHiDjIfZa9pR2tZMBGW8CmasvjoZl vrAHU1Q6opAF/0Ft7CzgUMy2/EiCN9kLnCQbVNgmZGf+utZif2ugy62aGGUUeIi/ +hhBTQEs9pOZPDCQXp0zIxekuiqoS1CxGLXqnUPipjyrBtXkm70df8hxO/7Ni1cs 8UeJKnh+DvW7aR/LCjbqeUa5suVvnRQvCF4o3gz8V/lTyHfUgknS/QxgUk9b4hRg o1kOUUqwyfGI2KtihVPD+VsFKw7S/iH1fi4hdhdnebm/NvBUqfgW2iyGhtW61ukr bnDJg05r6hbG9D0V2muT0jsYnrt3F/9Zfnkymw+4KeqfpII23yNCtWkQOQTpdtCg UqXFlFq4LVu184L44NGNtatXaxgl9GHHoni5BN7PPxajE9KTn5Q7+eVhyMCP3oTA 3UmEHXd0mcYu/wE9xcTR =aQMs -----END PGP SIGNATURE----- --nextPart1909581.LsadIkM7rP--