On Thursday, September 29, 2011 04:53:39 Yao Qi wrote: > On 09/29/2011 11:58 AM, Mike Frysinger wrote: > > --- a/gdb/common/linux-ptrace.h > > +++ b/gdb/common/linux-ptrace.h > > > > +#if (defined __bfin__ || defined __frv__ || defined __sh__) && \ > > + !defined PTRACE_GETFDPIC > > +#define PTRACE_GETFDPIC 31 > > +#define PTRACE_GETFDPIC_EXEC 0 > > +#define PTRACE_GETFDPIC_INTERP 1 > > +#endif > > Do you have some reasons to define these macros in common/? I don't see > these macros are/will be used in GDB, so maybe, we can move them in > gdbserver. Files in common/ are to have contents shared between gdb and > gdbserver. it isn't out of the realm of possibility to have a native gdb running which would need these ptrace defines. unlikely, but not impossible. this file seemed to be the best place for fallback linux ptrace defines. -mike