From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] h8300 target breakpoint doesn't work on Simulator
Date: Sat, 05 Mar 2011 03:27:00 -0000 [thread overview]
Message-ID: <20110305032632.GJ30306@adacore.com> (raw)
In-Reply-To: <201103041610.12924.vapier@gentoo.org>
> > - /*static unsigned char breakpoint[] = { 0x7A, 0xFF }; *//* ??? */
> > - static unsigned char breakpoint[] = { 0x01, 0x80 }; /* Sleep */
> > + static unsigned char breakpoint[] = { 0x7A, 0xFF }; /* bpt (only
> > simulator) */
>
> this sounds like you're fixing one system (sim) at the cost of
> breaking others (everyone else). this func is used by all h8300
> targets ... not just sim. so are you sure this is what you want ?
>
> try looking at the Blackfin tdep to see how we handle sim-specific bp's.
I was going to say exactly the very same thing.
--
Joel
next prev parent reply other threads:[~2011-03-05 3:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:38 Yoshinori Sato
2011-03-04 21:11 ` Mike Frysinger
2011-03-05 3:27 ` Joel Brobecker [this message]
2011-03-11 6:28 ` Yoshinori Sato
2011-03-11 6:58 ` Joel Brobecker
2011-03-16 14:15 ` Yoshinori Sato
2011-03-23 23:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110305032632.GJ30306@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox