From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15005 invoked by alias); 5 Mar 2011 03:27:02 -0000 Received: (qmail 14991 invoked by uid 22791); 5 Mar 2011 03:27:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Mar 2011 03:26:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 094022BADE6; Fri, 4 Mar 2011 22:26:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sys1Vx0Y5imP; Fri, 4 Mar 2011 22:26:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 275232BADD3; Fri, 4 Mar 2011 22:26:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5076D1459AD; Sat, 5 Mar 2011 07:26:32 +0400 (RET) Date: Sat, 05 Mar 2011 03:27:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, Yoshinori Sato Subject: Re: [PATCH] h8300 target breakpoint doesn't work on Simulator Message-ID: <20110305032632.GJ30306@adacore.com> References: <877hcen8ml.wl%ysato@users.sourceforge.jp> <201103041610.12924.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201103041610.12924.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00358.txt.bz2 > > - /*static unsigned char breakpoint[] = { 0x7A, 0xFF }; *//* ??? */ > > - static unsigned char breakpoint[] = { 0x01, 0x80 }; /* Sleep */ > > + static unsigned char breakpoint[] = { 0x7A, 0xFF }; /* bpt (only > > simulator) */ > > this sounds like you're fixing one system (sim) at the cost of > breaking others (everyone else). this func is used by all h8300 > targets ... not just sim. so are you sure this is what you want ? > > try looking at the Blackfin tdep to see how we handle sim-specific bp's. I was going to say exactly the very same thing. -- Joel