From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] h8300 target breakpoint doesn't work on Simulator
Date: Fri, 04 Mar 2011 21:11:00 -0000 [thread overview]
Message-ID: <201103041610.12924.vapier@gentoo.org> (raw)
In-Reply-To: <877hcen8ml.wl%ysato@users.sourceforge.jp>
[-- Attachment #1: Type: Text/Plain, Size: 984 bytes --]
On Friday, March 04, 2011 11:38:42 Yoshinori Sato wrote:
> h8300-elf simulator handling O_BPT instruction of breakpoint.
> But gdb write to O_SLEEP instruction of breakpoint.
>
> So breakpoint command doesn't work on h8300 simulator.
>
> --- h8300-tdep.c 25 Jan 2011 12:13:20 -0000 1.128
> +++ h8300-tdep.c 4 Mar 2011 16:31:41 -0000
> @@ -1197,8 +1197,7 @@
> h8300_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr,
> int *lenptr)
> {
> - /*static unsigned char breakpoint[] = { 0x7A, 0xFF }; *//* ??? */
> - static unsigned char breakpoint[] = { 0x01, 0x80 }; /* Sleep */
> + static unsigned char breakpoint[] = { 0x7A, 0xFF }; /* bpt (only
> simulator) */
this sounds like you're fixing one system (sim) at the cost of breaking others
(everyone else). this func is used by all h8300 targets ... not just sim. so
are you sure this is what you want ?
try looking at the Blackfin tdep to see how we handle sim-specific bp's.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-03-04 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 16:38 Yoshinori Sato
2011-03-04 21:11 ` Mike Frysinger [this message]
2011-03-05 3:27 ` Joel Brobecker
2011-03-11 6:28 ` Yoshinori Sato
2011-03-11 6:58 ` Joel Brobecker
2011-03-16 14:15 ` Yoshinori Sato
2011-03-23 23:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103041610.12924.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox