From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3179 invoked by alias); 4 Mar 2011 21:11:46 -0000 Received: (qmail 3153 invoked by uid 22791); 4 Mar 2011 21:11:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 21:11:37 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 012F71B40E7; Fri, 4 Mar 2011 21:11:36 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] h8300 target breakpoint doesn't work on Simulator Date: Fri, 04 Mar 2011 21:11:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.37; KDE/4.6.0; x86_64; ; ) Cc: Yoshinori Sato References: <877hcen8ml.wl%ysato@users.sourceforge.jp> In-Reply-To: <877hcen8ml.wl%ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1474404.lnuFfCCNlr"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201103041610.12924.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00325.txt.bz2 --nextPart1474404.lnuFfCCNlr Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 979 On Friday, March 04, 2011 11:38:42 Yoshinori Sato wrote: > h8300-elf simulator handling O_BPT instruction of breakpoint. > But gdb write to O_SLEEP instruction of breakpoint. >=20 > So breakpoint command doesn't work on h8300 simulator. >=20 > --- h8300-tdep.c 25 Jan 2011 12:13:20 -0000 1.128 > +++ h8300-tdep.c 4 Mar 2011 16:31:41 -0000 > @@ -1197,8 +1197,7 @@ > h8300_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr, > int *lenptr) > { > - /*static unsigned char breakpoint[] =3D { 0x7A, 0xFF }; *//* ??? */ > - static unsigned char breakpoint[] =3D { 0x01, 0x80 }; /* Sleep */ > + static unsigned char breakpoint[] =3D { 0x7A, 0xFF }; /* bpt (only > simulator) */ this sounds like you're fixing one system (sim) at the cost of breaking oth= ers=20 (everyone else). this func is used by all h8300 targets ... not just sim. = so=20 are you sure this is what you want ? try looking at the Blackfin tdep to see how we handle sim-specific bp's. -mike --nextPart1474404.lnuFfCCNlr Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJNcVU0AAoJEEFjO5/oN/WB++YP/0MeoLmjiQbtR8Poc71MK3ct xk5eM2C05sya0Ukgw/AvC9SgtMIK/OhV2/6skhv8oifc+CT3erh9g1GLZ67Tcx2D w38+abRHPblrW2BRplsAbUp7limAMrn5Nhu5txMCiey/6itnkjtb+M2JZ2b9VaWy 82IAfTlCnkAK/rXazc36mr+/pCYG+iwn8I0hukHOKKR4QYuVPLLoDajLwB99Gin6 vTkjZTD5VopMqIqOV8xVodBcLXMpUW1uyvBQVQYydAHlqqRe/Ri4jcoE+7Cp4Ds+ vW6NI2lDXpSnxRbiuAH4Z01UBgnIhmXhvJSs+xbMAswE0UyQsfkfz7P6pNgY8ZlD SvbjLNRnRr68xhI8gWAOKwFysnVpy1eb+bmnA8l+CehV2pAnptcsOJxoig3XXO5d x+Uk5bx6qgNGJUh4gE/gHBAQim3ktnPPAS6HAxNgEUF5ZcExKYFhE0yMaeOwQLHb mdgGqmvmjcdU9TmkzgobRjE1JhStGcMlbenCJbFcz2qmiIDNSdBhuxbTM2Gv/t1u Ym+r6AuY2KIsJkorlAiXcfIz3tHG0UG4HE5n7Q6dmr/9P9pf+x0BgkaopJ//FJxP emwrr4iE6y1A811D8nT0zcG/SLkyPbeaS95Iwg8UZMsOyXcqSGl7/kDIb8xEfZKK wld6EG750HADlwykEOLa =MLuT -----END PGP SIGNATURE----- --nextPart1474404.lnuFfCCNlr--