Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: [PATCH] h8300 target breakpoint doesn't work on Simulator
Date: Fri, 04 Mar 2011 16:38:00 -0000	[thread overview]
Message-ID: <877hcen8ml.wl%ysato@users.sourceforge.jp> (raw)

Hi

h8300-elf simulator handling O_BPT instruction of breakpoint.
But gdb write to O_SLEEP instruction of breakpoint.

So breakpoint command doesn't work on h8300 simulator.

I will fix this patch.
Thanks,

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.12730
diff -u -r1.12730 ChangeLog
--- ChangeLog	3 Mar 2011 18:35:31 -0000	1.12730
+++ ChangeLog	4 Mar 2011 16:31:41 -0000
@@ -1,3 +1,8 @@
+2011-03-04  Yoshinori Sato <ysato@users.sourceforge.jp>
+
+	* h8300-tdep.c (h8300_breakpoint_from_pc): Update to breakpoint
+	instruction
+
 2011-03-03  Tom Tromey  <tromey@redhat.com>
 
 	PR gdb/12538:
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.128
diff -u -r1.128 h8300-tdep.c
--- h8300-tdep.c	25 Jan 2011 12:13:20 -0000	1.128
+++ h8300-tdep.c	4 Mar 2011 16:31:41 -0000
@@ -1197,8 +1197,7 @@
 h8300_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr,
 			  int *lenptr)
 {
-  /*static unsigned char breakpoint[] = { 0x7A, 0xFF }; *//* ??? */
-  static unsigned char breakpoint[] = { 0x01, 0x80 };	/* Sleep */
+  static unsigned char breakpoint[] = { 0x7A, 0xFF };	/* bpt (only simulator) */
 
   *lenptr = sizeof (breakpoint);
   return breakpoint;
============================================================

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>


             reply	other threads:[~2011-03-04 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 16:38 Yoshinori Sato [this message]
2011-03-04 21:11 ` Mike Frysinger
2011-03-05  3:27   ` Joel Brobecker
2011-03-11  6:28   ` Yoshinori Sato
2011-03-11  6:58     ` Joel Brobecker
2011-03-16 14:15       ` Yoshinori Sato
2011-03-23 23:38         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hcen8ml.wl%ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox