From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] breakpoint.c, enable_command, missing break statement.
Date: Fri, 04 Mar 2011 19:28:00 -0000 [thread overview]
Message-ID: <201103041928.03380.pedro@codesourcery.com> (raw)
In-Reply-To: <4D713431.3060907@vmware.com>
On Friday 04 March 2011 18:49:21, Michael Snyder wrote:
> I'm not entirely sure what to do with this one.
>
> It clearly falls through, and it works as is, so the least change
> is just to comment it.
It looks irrelevant. The intent of the code is obviously
to iterate over all breakpoints, or all kinds.
The "continue" is continuing the loop hidden in
ALL_BREAKPOINTS at the next iteration. But if you replace
all the continue's with break's it will still work the same,
because the "break" would break the the "switch", not the
loop. I think if you do that the code ends up simpler to
read, with no magic.
--
Pedro Alves
next prev parent reply other threads:[~2011-03-04 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 18:49 Michael Snyder
2011-03-04 19:28 ` Pedro Alves [this message]
2011-03-04 19:58 ` Michael Snyder
2011-03-04 21:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103041928.03380.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox