From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] breakpoint.c, enable_command, missing break statement.
Date: Fri, 04 Mar 2011 18:49:00 -0000 [thread overview]
Message-ID: <4D713431.3060907@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 139 bytes --]
I'm not entirely sure what to do with this one.
It clearly falls through, and it works as is, so the least change
is just to comment it.
[-- Attachment #2: break9.txt --]
[-- Type: text/plain, Size: 639 bytes --]
2011-03-04 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
* breakpoint.c (enable_command): Document that case falls through.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.546
diff -u -p -u -p -r1.546 breakpoint.c
--- breakpoint.c 1 Mar 2011 02:16:56 -0000 1.546
+++ breakpoint.c 4 Mar 2011 18:45:43 -0000
@@ -11042,6 +11042,7 @@ enable_command (char *args, int from_tty
case bp_read_watchpoint:
case bp_access_watchpoint:
enable_breakpoint (bpt);
+ /* FALLTHROUGH */
default:
continue;
}
next reply other threads:[~2011-03-04 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 18:49 Michael Snyder [this message]
2011-03-04 19:28 ` Pedro Alves
2011-03-04 19:58 ` Michael Snyder
2011-03-04 21:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D713431.3060907@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox