From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18396 invoked by alias); 4 Mar 2011 19:28:08 -0000 Received: (qmail 18387 invoked by uid 22791); 4 Mar 2011 19:28:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 19:28:02 +0000 Received: (qmail 23693 invoked from network); 4 Mar 2011 19:28:00 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Mar 2011 19:28:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] breakpoint.c, enable_command, missing break statement. Date: Fri, 04 Mar 2011 19:28:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D713431.3060907@vmware.com> In-Reply-To: <4D713431.3060907@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103041928.03380.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00317.txt.bz2 On Friday 04 March 2011 18:49:21, Michael Snyder wrote: > I'm not entirely sure what to do with this one. > > It clearly falls through, and it works as is, so the least change > is just to comment it. It looks irrelevant. The intent of the code is obviously to iterate over all breakpoints, or all kinds. The "continue" is continuing the loop hidden in ALL_BREAKPOINTS at the next iteration. But if you replace all the continue's with break's it will still work the same, because the "break" would break the the "switch", not the loop. I think if you do that the code ends up simpler to read, with no magic. -- Pedro Alves