* [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)
@ 2011-03-03 18:32 Michael Snyder
2011-03-03 22:18 ` Alan Modra
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 18:32 UTC (permalink / raw)
To: nickc, gdb-patches, bug-binutils
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Hey Nick,
Should there be a break here? Or a "FALLTHROUGH" comment?
Looks like a break to me...
Cheers,
Michael
[-- Attachment #2: aoutx2.txt --]
[-- Type: text/plain, Size: 663 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* aoutx.h (aout_link_write_other_symbol): Missing break statement.
Index: aoutx.h
===================================================================
RCS file: /cvs/src/src/bfd/aoutx.h,v
retrieving revision 1.85
diff -u -p -u -p -r1.85 aoutx.h
--- aoutx.h 13 Dec 2010 01:06:15 -0000 1.85
+++ aoutx.h 3 Mar 2011 18:28:37 -0000
@@ -3637,6 +3637,7 @@ aout_link_write_other_symbol (struct aou
case bfd_link_hash_undefweak:
type = N_WEAKU;
val = 0;
+ break;
case bfd_link_hash_indirect:
/* We ignore these symbols, since the indirected symbol is
already in the hash table. */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)
2011-03-03 18:32 [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?) Michael Snyder
@ 2011-03-03 22:18 ` Alan Modra
2011-03-03 23:48 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2011-03-03 22:18 UTC (permalink / raw)
To: Michael Snyder; +Cc: nickc, gdb-patches, bug-binutils
On Thu, Mar 03, 2011 at 10:32:18AM -0800, Michael Snyder wrote:
> * aoutx.h (aout_link_write_other_symbol): Missing break statement.
OK.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)
2011-03-03 22:18 ` Alan Modra
@ 2011-03-03 23:48 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-03 23:48 UTC (permalink / raw)
To: Michael Snyder, nickc, gdb-patches, bug-binutils
Alan Modra wrote:
> On Thu, Mar 03, 2011 at 10:32:18AM -0800, Michael Snyder wrote:
>> * aoutx.h (aout_link_write_other_symbol): Missing break statement.
>
> OK.
>
Committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-03 23:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-03 18:32 [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?) Michael Snyder
2011-03-03 22:18 ` Alan Modra
2011-03-03 23:48 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox