From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9063 invoked by alias); 3 Mar 2011 18:32:24 -0000 Received: (qmail 9054 invoked by uid 22791); 3 Mar 2011 18:32:24 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 18:32:20 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 356915A020; Thu, 3 Mar 2011 10:32:19 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 130BBCDA4A; Thu, 3 Mar 2011 10:32:18 -0800 (PST) Message-ID: <4D6FDEB2.2090900@vmware.com> Date: Thu, 03 Mar 2011 18:32:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: nickc@redhat.com, "gdb-patches@sourceware.org" , bug-binutils@gnu.org Subject: [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?) Content-Type: multipart/mixed; boundary="------------090608010506000809030800" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00199.txt.bz2 This is a multi-part message in MIME format. --------------090608010506000809030800 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 116 Hey Nick, Should there be a break here? Or a "FALLTHROUGH" comment? Looks like a break to me... Cheers, Michael --------------090608010506000809030800 Content-Type: text/plain; name="aoutx2.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="aoutx2.txt" Content-length: 663 2011-03-03 Michael Snyder * aoutx.h (aout_link_write_other_symbol): Missing break statement. Index: aoutx.h =================================================================== RCS file: /cvs/src/src/bfd/aoutx.h,v retrieving revision 1.85 diff -u -p -u -p -r1.85 aoutx.h --- aoutx.h 13 Dec 2010 01:06:15 -0000 1.85 +++ aoutx.h 3 Mar 2011 18:28:37 -0000 @@ -3637,6 +3637,7 @@ aout_link_write_other_symbol (struct aou case bfd_link_hash_undefweak: type = N_WEAKU; val = 0; + break; case bfd_link_hash_indirect: /* We ignore these symbols, since the indirected symbol is already in the hash table. */ --------------090608010506000809030800--