From: Michael Snyder <msnyder@vmware.com>
To: nickc@redhat.com,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
bug-binutils@gnu.org
Subject: [RFA] aoutx.h, aout_link_write_other_symbol, missing break statement (?)
Date: Thu, 03 Mar 2011 18:32:00 -0000 [thread overview]
Message-ID: <4D6FDEB2.2090900@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 116 bytes --]
Hey Nick,
Should there be a break here? Or a "FALLTHROUGH" comment?
Looks like a break to me...
Cheers,
Michael
[-- Attachment #2: aoutx2.txt --]
[-- Type: text/plain, Size: 663 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* aoutx.h (aout_link_write_other_symbol): Missing break statement.
Index: aoutx.h
===================================================================
RCS file: /cvs/src/src/bfd/aoutx.h,v
retrieving revision 1.85
diff -u -p -u -p -r1.85 aoutx.h
--- aoutx.h 13 Dec 2010 01:06:15 -0000 1.85
+++ aoutx.h 3 Mar 2011 18:28:37 -0000
@@ -3637,6 +3637,7 @@ aout_link_write_other_symbol (struct aou
case bfd_link_hash_undefweak:
type = N_WEAKU;
val = 0;
+ break;
case bfd_link_hash_indirect:
/* We ignore these symbols, since the indirected symbol is
already in the hash table. */
next reply other threads:[~2011-03-03 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 18:32 Michael Snyder [this message]
2011-03-03 22:18 ` Alan Modra
2011-03-03 23:48 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6FDEB2.2090900@vmware.com \
--to=msnyder@vmware.com \
--cc=bug-binutils@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox