From: Pedro Alves <pedro@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] linespec.c, decode_line_1, check for null.
Date: Tue, 01 Mar 2011 22:08:00 -0000 [thread overview]
Message-ID: <201103012208.28337.pedro@codesourcery.com> (raw)
In-Reply-To: <4D6D6D2A.6070008@vmware.com>
On Tuesday 01 March 2011 22:03:22, Michael Snyder wrote:
> Pedro Alves wrote:
> > On Tuesday 01 March 2011 21:43:27, Michael Snyder wrote:
> >> Pedro Alves wrote:
> >>> On Tuesday 01 March 2011 20:57:30, Michael Snyder wrote:
> >>>> If it's worth checking for null, it's worth doing so before the first
> >>>> dereference.
> >>> Well, then it may not be worth checking for null. How old is
> >>> that code?
> >> It predates me, and I've been on gdb since 1995. ;-)
> >
> > :-)
> >
> > Then I think it's safe to say that if we haven't seen
> > a NULL-dereference crash in over 15 years, it's because it's
> > not really necessary.
> >
>
> Ok then -- you'd prefer it like this?
Yep. Thanks.
--
Pedro Alves
prev parent reply other threads:[~2011-03-01 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 20:57 Michael Snyder
2011-03-01 21:25 ` Pedro Alves
2011-03-01 21:43 ` Michael Snyder
2011-03-01 21:50 ` Pedro Alves
2011-03-01 22:03 ` Michael Snyder
2011-03-01 22:08 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103012208.28337.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox