[commit] linespec.c, decode_line_1, check for null.

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 98 bytes --]

If it's worth checking for null, it's worth doing so before the first 
dereference.

Checked in.


[-- Attachment #2: reversenull4.txt --]
[-- Type: text/plain, Size: 1254 bytes --]

2011-03-01  Michael Snyder  <msnyder@vmware.com>

	* linespec.c (decode_line_1): Check for null before dereference.

Index: linespec.c
===================================================================
RCS file: /cvs/src/src/gdb/linespec.c,v
retrieving revision 1.110
diff -u -p -u -p -r1.110 linespec.c
--- linespec.c	1 Mar 2011 00:26:14 -0000	1.110
+++ linespec.c	1 Mar 2011 20:53:54 -0000
@@ -726,7 +726,7 @@ decode_line_1 (char **argptr, int funfir
   char *copy;
   /* This says whether or not something in *ARGPTR is quoted with
      completer_quotes (i.e. with single quotes).  */
-  int is_quoted;
+  int is_quoted = 0;
   /* Is *ARGPTR is enclosed in double quotes?  */
   int is_quote_enclosed;
   int is_objc_method = 0;
@@ -745,12 +745,15 @@ decode_line_1 (char **argptr, int funfir
   
   /* See if arg is *PC.  */
 
-  if (**argptr == '*')
-    return decode_indirect (argptr);
+  if (*argptr)
+    {
+      if (**argptr == '*')
+	return decode_indirect (argptr);
+
+      is_quoted = (strchr (get_gdb_completer_quote_characters (),
+			   **argptr) != NULL);
+    }
 
-  is_quoted = (*argptr
-	       && strchr (get_gdb_completer_quote_characters (),
-			  **argptr) != NULL);
   if (is_quoted)
     end_quote = skip_quoted (*argptr);