Re: [commit] linespec.c, decode_line_1, check for null.

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Pedro Alves wrote:
> On Tuesday 01 March 2011 21:43:27, Michael Snyder wrote:
>> Pedro Alves wrote:
>>> On Tuesday 01 March 2011 20:57:30, Michael Snyder wrote:
>>>> If it's worth checking for null, it's worth doing so before the first 
>>>> dereference.
>>> Well, then it may not be worth checking for null.  How old is
>>> that code?  
>> It predates me, and I've been on gdb since 1995.   ;-)
> 
> :-)
> 
> Then I think it's safe to say that if we haven't seen
> a NULL-dereference crash in over 15 years, it's because it's
> not really necessary.
> 

Ok then -- you'd prefer it like this?



[-- Attachment #2: reversenull8.txt --]
[-- Type: text/plain, Size: 1232 bytes --]

2011-03-01  Michael Snyder  <msnyder@vmware.com>

	* linespec.c (decode_line_1): Remove unnecessary null check.

Index: linespec.c
===================================================================
RCS file: /cvs/src/src/gdb/linespec.c,v
retrieving revision 1.111
diff -u -p -u -p -r1.111 linespec.c
--- linespec.c	1 Mar 2011 20:57:52 -0000	1.111
+++ linespec.c	1 Mar 2011 22:01:07 -0000
@@ -726,7 +726,7 @@ decode_line_1 (char **argptr, int funfir
   char *copy;
   /* This says whether or not something in *ARGPTR is quoted with
      completer_quotes (i.e. with single quotes).  */
-  int is_quoted = 0;
+  int is_quoted;
   /* Is *ARGPTR is enclosed in double quotes?  */
   int is_quote_enclosed;
   int is_objc_method = 0;
@@ -745,14 +745,11 @@ decode_line_1 (char **argptr, int funfir
   
   /* See if arg is *PC.  */
 
-  if (*argptr)
-    {
-      if (**argptr == '*')
-	return decode_indirect (argptr);
+  if (**argptr == '*')
+    return decode_indirect (argptr);
 
-      is_quoted = (strchr (get_gdb_completer_quote_characters (),
-			   **argptr) != NULL);
-    }
+  is_quoted = (strchr (get_gdb_completer_quote_characters (),
+		       **argptr) != NULL);
 
   if (is_quoted)
     end_quote = skip_quoted (*argptr);