From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14753 invoked by alias); 1 Mar 2011 22:08:36 -0000 Received: (qmail 14741 invoked by uid 22791); 1 Mar 2011 22:08:35 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 22:08:31 +0000 Received: (qmail 30642 invoked from network); 1 Mar 2011 22:08:30 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Mar 2011 22:08:29 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [commit] linespec.c, decode_line_1, check for null. Date: Tue, 01 Mar 2011 22:08:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4D6D5DBA.90604@vmware.com> <201103012150.16696.pedro@codesourcery.com> <4D6D6D2A.6070008@vmware.com> In-Reply-To: <4D6D6D2A.6070008@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103012208.28337.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00062.txt.bz2 On Tuesday 01 March 2011 22:03:22, Michael Snyder wrote: > Pedro Alves wrote: > > On Tuesday 01 March 2011 21:43:27, Michael Snyder wrote: > >> Pedro Alves wrote: > >>> On Tuesday 01 March 2011 20:57:30, Michael Snyder wrote: > >>>> If it's worth checking for null, it's worth doing so before the first > >>>> dereference. > >>> Well, then it may not be worth checking for null. How old is > >>> that code? > >> It predates me, and I've been on gdb since 1995. ;-) > > > > :-) > > > > Then I think it's safe to say that if we haven't seen > > a NULL-dereference crash in over 15 years, it's because it's > > not really necessary. > > > > Ok then -- you'd prefer it like this? Yep. Thanks. -- Pedro Alves