From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] sim: bfin: new port
Date: Tue, 22 Feb 2011 17:58:00 -0000 [thread overview]
Message-ID: <201102221257.43592.vapier@gentoo.org> (raw)
In-Reply-To: <20110222082010.GP2600@adacore.com>
[-- Attachment #1: Type: Text/Plain, Size: 869 bytes --]
On Tuesday, February 22, 2011 03:20:10 Joel Brobecker wrote:
> > > I'm not a sim expert, so I can only provide cosmetic review.
> > > However, I did notice a couple of important things: The copyright
> > > headers should mention 2011, and the license should be GPL version 3.
> >
> > all the files do say 2011 that i can see ... were there ones missing that
> > you saw ?
>
> The ones I saw were at the beginning of the patch. For instance:
>
> +++ b/include/gdb/sim-bfin.h
> + Copyright (C) 2005 Free Software Foundation, Inc.
>
> +++ b/sim/bfin/Makefile.in
> +# Copyright (C) 2005 Free Software Foundation, Inc.
ah, *those* files :). i had checked all the .c/.h files in sim/bfin/, but
forgot to look at the others.
> For new contributions, I don't see a reason for licensing it GPL v2,
> so let's go with v3.
np, will do
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-02-22 17:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 1:41 [PATCH] " Mike Frysinger
2010-12-31 23:12 ` [PATCH v2] " Mike Frysinger
2011-02-14 20:18 ` [PATCH v3] " Mike Frysinger
2011-02-14 20:49 ` Pedro Alves
2011-02-14 21:12 ` Mike Frysinger
2011-02-14 21:55 ` Pedro Alves
2011-02-14 22:11 ` Mike Frysinger
2011-02-14 22:23 ` Mike Frysinger
2011-02-15 16:25 ` Pedro Alves
2011-02-16 1:34 ` Mike Frysinger
2011-02-16 5:34 ` Joel Brobecker
2011-02-20 7:24 ` Mike Frysinger
2011-02-21 10:13 ` Joel Brobecker
2011-02-21 18:27 ` Mike Frysinger
2011-02-22 8:28 ` Joel Brobecker
2011-02-22 17:58 ` Mike Frysinger [this message]
2011-02-22 10:50 ` Pedro Alves
2011-02-22 18:07 ` Mike Frysinger
2011-02-22 10:08 ` Pedro Alves
2011-02-22 17:57 ` Mike Frysinger
2011-02-22 18:25 ` Pedro Alves
2011-02-22 20:54 ` Mike Frysinger
2011-02-22 20:29 ` [PATCH v5] " Mike Frysinger
2011-03-01 5:16 ` Mike Frysinger
2011-03-01 10:11 ` Joel Brobecker
2011-03-01 21:19 ` Pedro Alves
2011-03-01 23:42 ` Mike Frysinger
2011-03-02 1:13 ` Pedro Alves
2011-03-02 2:23 ` Mike Frysinger
2011-03-02 9:30 ` Pedro Alves
2011-03-02 21:46 ` Mike Frysinger
2011-03-02 23:32 ` Pedro Alves
2011-03-02 23:32 ` Pedro Alves
2011-03-03 21:40 ` [PATCH v6] " Mike Frysinger
2011-03-04 10:19 ` Pedro Alves
2011-03-04 21:12 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102221257.43592.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox