On Tuesday, February 22, 2011 03:20:10 Joel Brobecker wrote:
> > > I'm not a sim expert, so I can only provide cosmetic review.
> > > However, I did notice a couple of important things: The copyright
> > > headers should mention 2011, and the license should be GPL version 3.
> > 
> > all the files do say 2011 that i can see ... were there ones missing that
> > you saw ?
> 
> The ones I saw were at the beginning of the patch.  For instance:
> 
> +++ b/include/gdb/sim-bfin.h
> +   Copyright (C) 2005 Free Software Foundation, Inc.
> 
> +++ b/sim/bfin/Makefile.in
> +#    Copyright (C) 2005 Free Software Foundation, Inc.

ah, *those* files :).  i had checked all the .c/.h files in sim/bfin/, but 
forgot to look at the others.

> For new contributions, I don't see a reason for licensing it GPL v2,
> so let's go with v3.

np, will do
-mike