From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31141 invoked by alias); 22 Feb 2011 17:57:53 -0000 Received: (qmail 31133 invoked by uid 22791); 22 Feb 2011 17:57:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 17:57:46 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id A5B841B4015; Tue, 22 Feb 2011 17:57:44 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH v3] sim: bfin: new port Date: Tue, 22 Feb 2011 17:58:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.37; KDE/4.6.0; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201011152039.08285.vapier@gentoo.org> <201102211153.47019.vapier@gentoo.org> <20110222082010.GP2600@adacore.com> In-Reply-To: <20110222082010.GP2600@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart46372314.EpaTmrL6NY"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201102221257.43592.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00603.txt.bz2 --nextPart46372314.EpaTmrL6NY Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 859 On Tuesday, February 22, 2011 03:20:10 Joel Brobecker wrote: > > > I'm not a sim expert, so I can only provide cosmetic review. > > > However, I did notice a couple of important things: The copyright > > > headers should mention 2011, and the license should be GPL version 3. > >=20 > > all the files do say 2011 that i can see ... were there ones missing th= at > > you saw ? >=20 > The ones I saw were at the beginning of the patch. For instance: >=20 > +++ b/include/gdb/sim-bfin.h > + Copyright (C) 2005 Free Software Foundation, Inc. >=20 > +++ b/sim/bfin/Makefile.in > +# Copyright (C) 2005 Free Software Foundation, Inc. ah, *those* files :). i had checked all the .c/.h files in sim/bfin/, but= =20 forgot to look at the others. > For new contributions, I don't see a reason for licensing it GPL v2, > so let's go with v3. np, will do -mike --nextPart46372314.EpaTmrL6NY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJNY/kXAAoJEEFjO5/oN/WBYXUP/20eEqLNfI/VsQGjTdPAUL4q bPjv22b711bVurayxzGxyuz+eEBob3pcX5M/qqOZ3B4k8eNL6NUCpUrL0TBmDGZe 2dKgtZkfc9washLth+pqBuk/9tInqTlgB7D+FwERXXFdKDgB2rFOz3PeQNOidmk7 ocv4DZcHYBMR5SFmS1IhM1X2LslUf3XmeFcYN4dHpme+81taJ1jKI495v9vLBRsU S27yPg2rpPLRz54i7ew35lisvS63QLG+iy1PCFYzTnbJoFtgNbelWYIVTo1DV9WB j5UuVvc6t9VmbIrD/NJ0CcQw1wCVKuyZCplm0W2JXnHr2tFCqrZoSei2rLPtlXMA pLcnjEcQFlMuyHgINBMKjDTZckj/qXLvQF7Z8FjZ0g/QTtlGFs+Ju1XUH8BlwWBU jhM5fL3KLlWbI96VdMWLV45vq8NqBtyZrarfS57l6hPUwX+cHIjbqs3vov2D9bj4 8rwKq+ME1jt7dK6zSGz1m5+iSyC0E3AN8Nn66yJYqo0cmcyrXDnmIAXDH4a4kz3D AlZdbLm1qoXC+5GG30onnqnVfGdpI/HcL0avabHYSoEBbwknicwR3SqqzgQhfLht FDN0ZD8UuwVOMJSvOIbcmuSeYL2j5oRIHn7nRyTGBLIuFeyf1Vpp7YKAupzV1hX9 +qtteviC+MbUUYFyKyIA =e1Kb -----END PGP SIGNATURE----- --nextPart46372314.EpaTmrL6NY--