Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v5] sim: bfin: new port
Date: Tue, 01 Mar 2011 21:19:00 -0000	[thread overview]
Message-ID: <201103012119.26255.pedro@codesourcery.com> (raw)
In-Reply-To: <201102221526.45398.vapier@gentoo.org>

Hi Mike,

On Tuesday 22 February 2011 20:26:44, Mike Frysinger wrote:

> --- /dev/null
> +++ b/sim/bfin/linux-fixed-code.h
> @@ -0,0 +1,23 @@
> +/* DO NOT EDIT: Autogenerated.  */
> +/* Fixed code region of Linux userspace starting at 0x400.  Last produced
> +   from Linux-2.6.37 (not that the fixed code region changes often).  */
> +static const unsigned char bfin_linux_fixed_code[] = {
> +0x28, 0xe1, 0xad, 0x00, 0xa0, 0x00, 0x00, 0x20,
(...)
> +0xa4, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> +};

I was surprised to still see a binary blob in
the code, and though this blog was generated from a
different source, I also worry about it.  :-(
AINAL yadda yadda.

From the comment, this blob in question is a dump of code
from the Linux kernel.  In short, you're making the
gdb sources include a piece of the Linux kernel.

The whole Linux kernel as a single product is GPLv2.
If that was indeed extracted from a Linux kernel's
binary (either from a running system or from the
object code), then from my understanding it is
GPLv2 as well, and retains the original copyright of
the Kernel, as (sic from the GPL FAQ) 'when a program
translates its input into some other form, the copyright
status of the output inherits that of the input
it was generated from'.

This seem to make that hunk in the patch not acceptable,
as GPLv2 is incompatible with GPLv3.

There's then the issue that since the blob is
a GPLv2 binary, to distribute/convey it, per the GPL,
we'd need to be able to provide the source it's
generated from as well.  And any scripts/instructions
necessary to regenerate the autogenerated file.

(It is also my understanding that when you distribute/convey
object code, you must keep copyright notices
intact, and I would assume that to mean that
even these generated files should carry a copyright
(and license) header.)

Now this kernel code in question was probably (haven't
checked) largely written by ADI, and as such ADI could
probably contribute a standalone version of its source
to the FSF under GPLv3, along with some script or makefile
that compiles it with a bfin-gcc and then generates
the blob array.  Or you could write simple dumb
replacement implementations of the interface instead?

I don't know if there's some rule or exception
in the GPL that applies here, and nullifies my concerns.
I'd be happy to learn about it.

I think that best would be for you to contact
<assign@gnu.org> and get an educated answer from
the FSF (Cc'ing me).

-- 
Pedro Alves


  parent reply	other threads:[~2011-03-01 21:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16  1:41 [PATCH] " Mike Frysinger
2010-12-31 23:12 ` [PATCH v2] " Mike Frysinger
2011-02-14 20:18   ` [PATCH v3] " Mike Frysinger
2011-02-14 20:49     ` Pedro Alves
2011-02-14 21:12       ` Mike Frysinger
2011-02-14 21:55         ` Pedro Alves
2011-02-14 22:11           ` Mike Frysinger
2011-02-14 22:23             ` Mike Frysinger
2011-02-15 16:25             ` Pedro Alves
2011-02-16  1:34               ` Mike Frysinger
2011-02-16  5:34                 ` Joel Brobecker
2011-02-20  7:24     ` Mike Frysinger
2011-02-21 10:13       ` Joel Brobecker
2011-02-21 18:27         ` Mike Frysinger
2011-02-22  8:28           ` Joel Brobecker
2011-02-22 17:58             ` Mike Frysinger
2011-02-22 10:50           ` Pedro Alves
2011-02-22 18:07             ` Mike Frysinger
2011-02-22 10:08         ` Pedro Alves
2011-02-22 17:57           ` Mike Frysinger
2011-02-22 18:25             ` Pedro Alves
2011-02-22 20:54               ` Mike Frysinger
2011-02-22 20:29       ` [PATCH v5] " Mike Frysinger
2011-03-01  5:16         ` Mike Frysinger
2011-03-01 10:11         ` Joel Brobecker
2011-03-01 21:19         ` Pedro Alves [this message]
2011-03-01 23:42           ` Mike Frysinger
2011-03-02  1:13             ` Pedro Alves
2011-03-02  2:23               ` Mike Frysinger
2011-03-02  9:30                 ` Pedro Alves
2011-03-02 21:46                   ` Mike Frysinger
2011-03-02 23:32                     ` Pedro Alves
2011-03-02 23:32                     ` Pedro Alves
2011-03-03 21:40         ` [PATCH v6] " Mike Frysinger
2011-03-04 10:19           ` Pedro Alves
2011-03-04 21:12             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103012119.26255.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox