Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patch] Fix fileio.exp failuew when run as root user.
Date: Wed, 15 Dec 2010 05:12:00 -0000	[thread overview]
Message-ID: <20101215051138.GZ2596@adacore.com> (raw)
In-Reply-To: <201012140955.23411.pedro@codesourcery.com>

> Note that this test is meant to test remote file io capabilities.
> The fact that it runs on a native gdb is merely a way to give it
> a bit more exposure against bitrot.  We need to make sure to not
> simply fail the test if the syscalls we're introducing are not supported
> by remote file io (remote-fileio.c), and they fail on the
> target (e.g., ENOSYS), and also that the test still compiles on
> bare metal targets, with e.g., newlib (otherwise, the test becomes
> useless).  (The test was probably running on Windows/mingw as well,
> but the "geteuid" call introduction is probably making it not compile
> there anymore.)

So, as it is, the fix doesn't meet those requirements and shouldn't
be applied, right?  If that's the case, then perhaps the first question
is to figure out why someone is running the testsuite as root... Is
that a sysadmin who is building GDB as root?

I had checked that the new functions used are defined by POSIX,
but confess I never worried about Windows. Sorry.

-- 
Joel


  reply	other threads:[~2010-12-15  5:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 16:34 Phil Muldoon
2010-12-14  6:58 ` Joel Brobecker
2010-12-14  9:55   ` Pedro Alves
2010-12-15  5:12     ` Joel Brobecker [this message]
2010-12-15  7:46       ` Phil Muldoon
2010-12-14  9:08 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101215051138.GZ2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox