From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25177 invoked by alias); 15 Dec 2010 05:12:03 -0000 Received: (qmail 25132 invoked by uid 22791); 15 Dec 2010 05:12:01 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 05:11:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5E7872BAB49; Wed, 15 Dec 2010 00:11:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xQMwexUqOaO2; Wed, 15 Dec 2010 00:11:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D53982BAADA; Wed, 15 Dec 2010 00:11:51 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6BF58145B58; Wed, 15 Dec 2010 06:11:38 +0100 (CET) Date: Wed, 15 Dec 2010 05:12:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org, Phil Muldoon Subject: Re: [patch] Fix fileio.exp failuew when run as root user. Message-ID: <20101215051138.GZ2596@adacore.com> References: <20101214065744.GN2596@adacore.com> <201012140955.23411.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012140955.23411.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00279.txt.bz2 > Note that this test is meant to test remote file io capabilities. > The fact that it runs on a native gdb is merely a way to give it > a bit more exposure against bitrot. We need to make sure to not > simply fail the test if the syscalls we're introducing are not supported > by remote file io (remote-fileio.c), and they fail on the > target (e.g., ENOSYS), and also that the test still compiles on > bare metal targets, with e.g., newlib (otherwise, the test becomes > useless). (The test was probably running on Windows/mingw as well, > but the "geteuid" call introduction is probably making it not compile > there anymore.) So, as it is, the fix doesn't meet those requirements and shouldn't be applied, right? If that's the case, then perhaps the first question is to figure out why someone is running the testsuite as root... Is that a sysadmin who is building GDB as root? I had checked that the new functions used are defined by POSIX, but confess I never worried about Windows. Sorry. -- Joel