Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix fileio.exp failuew when run as root user.
Date: Tue, 14 Dec 2010 06:58:00 -0000	[thread overview]
Message-ID: <20101214065744.GN2596@adacore.com> (raw)
In-Reply-To: <m3bp5ll1c5.fsf@redhat.com>

> 2010-11-19  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.base/fileio.c (ROOTSUBDIR): New macro.
> 	(main): CHDIR into ROOTSUBDIR.  CHOWN ROOTSUBDIR and CHDIR into
> 	ROOTSUBDIR if we are being run as root.
> 	* gdb.base/fileio.exp: Change the startup and finish cleanup.
> 	Change the test file reference to be into the `fileio.dir' directory.

Did anyone comment on that patch?  This looks OK to me.

(why would anyone want to run the testsuite as root, though???)

-- 
Joel


  reply	other threads:[~2010-12-14  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 16:34 Phil Muldoon
2010-12-14  6:58 ` Joel Brobecker [this message]
2010-12-14  9:55   ` Pedro Alves
2010-12-15  5:12     ` Joel Brobecker
2010-12-15  7:46       ` Phil Muldoon
2010-12-14  9:08 ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101214065744.GN2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox