From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>,
Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patch] Fix fileio.exp failuew when run as root user.
Date: Tue, 14 Dec 2010 09:55:00 -0000 [thread overview]
Message-ID: <201012140955.23411.pedro@codesourcery.com> (raw)
In-Reply-To: <20101214065744.GN2596@adacore.com>
On Tuesday 14 December 2010 06:57:44, Joel Brobecker wrote:
> > 2010-11-19 Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > * gdb.base/fileio.c (ROOTSUBDIR): New macro.
> > (main): CHDIR into ROOTSUBDIR. CHOWN ROOTSUBDIR and CHDIR into
> > ROOTSUBDIR if we are being run as root.
> > * gdb.base/fileio.exp: Change the startup and finish cleanup.
> > Change the test file reference to be into the `fileio.dir' directory.
>
> Did anyone comment on that patch? This looks OK to me.
>
> (why would anyone want to run the testsuite as root, though???)
Note that this test is meant to test remote file io capabilities.
The fact that it runs on a native gdb is merely a way to give it
a bit more exposure against bitrot. We need to make sure to not
simply fail the test if the syscalls we're introducing are not supported
by remote file io (remote-fileio.c), and they fail on the
target (e.g., ENOSYS), and also that the test still compiles on
bare metal targets, with e.g., newlib (otherwise, the test becomes
useless). (The test was probably running on Windows/mingw as well,
but the "geteuid" call introduction is probably making it not compile
there anymore.)
--
Pedro Alves
next prev parent reply other threads:[~2010-12-14 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 16:34 Phil Muldoon
2010-12-14 6:58 ` Joel Brobecker
2010-12-14 9:55 ` Pedro Alves [this message]
2010-12-15 5:12 ` Joel Brobecker
2010-12-15 7:46 ` Phil Muldoon
2010-12-14 9:08 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012140955.23411.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox