From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH v2] sim: add --map-info option
Date: Wed, 15 Dec 2010 05:02:00 -0000 [thread overview]
Message-ID: <20101215050226.GX2596@adacore.com> (raw)
In-Reply-To: <1292351771-16396-1-git-send-email-vapier@gentoo.org>
> 2010-12-14 Mike Frysinger <vapier@gentoo.org>
>
> * sim-memopt.c (OPTION_MAP_INFO): Define.
> (memory_options): Handle --map-info.
> (memory_option_handler): Handle OPTION_MAP_INFO.
> ---
> v2
> - convert to map_to_str
> - drop long casts where unnecessary
This looks OK to me. If I read your discussion with Pedro correctly,
he's OK too, so OK to commit.
One last request: Can you send a patch adding a note in the gdb/NEWS file?
Thank you,
--
Joel
next prev parent reply other threads:[~2010-12-15 5:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 16:15 [PATCH] " Mike Frysinger
2010-12-14 7:36 ` Joel Brobecker
2010-12-14 15:17 ` Mike Frysinger
2010-12-14 18:34 ` Mike Frysinger
2010-12-14 18:50 ` Pedro Alves
2010-12-14 19:03 ` Mike Frysinger
2010-12-14 19:12 ` Pedro Alves
2010-12-14 19:30 ` Mike Frysinger
2010-12-15 4:54 ` Joel Brobecker
2010-12-15 11:50 ` Mike Frysinger
2010-12-14 18:37 ` [PATCH v2] " Mike Frysinger
2010-12-15 5:02 ` Joel Brobecker [this message]
2010-12-15 11:21 ` Mike Frysinger
2010-12-15 11:48 ` Joel Brobecker
2010-12-15 12:02 ` [toolchain-devel] " Mike Frysinger
2010-12-15 13:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215050226.GX2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox