Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org,
	Joel Brobecker <brobecker@adacore.com>,
	Stephen.Kilbane@analog.com, Stuart.Henderson@analog.com,
	David.Gibson@analog.com
Subject: Re: [PATCH] sim: add --map-info option
Date: Tue, 14 Dec 2010 19:12:00 -0000	[thread overview]
Message-ID: <201012141912.00225.pedro@codesourcery.com> (raw)
In-Reply-To: <201012141403.04352.vapier@gentoo.org>

On Tuesday 14 December 2010 19:03:02, Mike Frysinger wrote:
> On Tuesday, December 14, 2010 13:50:27 Pedro Alves wrote:
> > On Tuesday 14 December 2010 18:33:09, Mike Frysinger wrote:
> > > ok, some of the (long) casts are necessary.  specifically, the ones who
> > > have a type of "unsigned_word" as those depend on the target bitness
> > > (which could be 16, 32, or 64).
> > 
> > long is 32-bit on Win64.
> 
> so what you're saying is that all the sim code that casts unsigned_word to a 
> long is broken and not just the code in my patch.  sounds like a bigger 
> problem that should be fixed independently and by someone who is interested in 
> testing on systems dumb enough to do LLP64.

No, I just said "long is 32-bit on Win64".

I just noticed src/README-HACKING:

C Language Assumptions
======================

The programmer may assume that the simulator is being built using an
ANSI C compiler that supports a 64 bit data type.  Consequently:

	o	prototypes can be used (although using
		PARAMS() and K&R declarations wouldn't
		go astray).

	o	If sim-types.h is included, the two
		types signed64 and unsigned64 are
		available.

	o	The type `unsigned' is valid.

However, the user should be aware of the following:

	o	GCC's `<number>LL' is NOT acceptable.
		Microsoft-C doesn't reconize it.

	o	MSC's `<number>i64' is NOT acceptable.
		GCC doesn't reconize it.

	o	GCC's `long long' MSC's `_int64' can
		NOT be used to define 64 bit integer data
		types.

	o	An empty array (eg int a[0]) is not valid.


but if the sim is already not following its own rules, let's leave it.
For GDB code proper, long would be unacceptible.

-- 
Pedro Alves


  reply	other threads:[~2010-12-14 19:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 16:15 Mike Frysinger
2010-12-14  7:36 ` Joel Brobecker
2010-12-14 15:17   ` Mike Frysinger
2010-12-14 18:34     ` Mike Frysinger
2010-12-14 18:50       ` Pedro Alves
2010-12-14 19:03         ` Mike Frysinger
2010-12-14 19:12           ` Pedro Alves [this message]
2010-12-14 19:30             ` Mike Frysinger
2010-12-15  4:54     ` Joel Brobecker
2010-12-15 11:50       ` Mike Frysinger
2010-12-14 18:37 ` [PATCH v2] " Mike Frysinger
2010-12-15  5:02   ` Joel Brobecker
2010-12-15 11:21     ` Mike Frysinger
2010-12-15 11:48       ` Joel Brobecker
2010-12-15 12:02         ` [toolchain-devel] " Mike Frysinger
2010-12-15 13:16           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012141912.00225.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=David.Gibson@analog.com \
    --cc=Stephen.Kilbane@analog.com \
    --cc=Stuart.Henderson@analog.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox