From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 497 invoked by alias); 14 Dec 2010 19:12:31 -0000 Received: (qmail 484 invoked by uid 22791); 14 Dec 2010 19:12:29 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 19:12:24 +0000 Received: (qmail 19168 invoked from network); 14 Dec 2010 19:12:23 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Dec 2010 19:12:23 -0000 From: Pedro Alves To: Mike Frysinger Subject: Re: [PATCH] sim: add --map-info option Date: Tue, 14 Dec 2010 19:12:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: gdb-patches@sourceware.org, Joel Brobecker , Stephen.Kilbane@analog.com, Stuart.Henderson@analog.com, David.Gibson@analog.com References: <1291219863-18458-1-git-send-email-vapier@gentoo.org> <201012141850.28267.pedro@codesourcery.com> <201012141403.04352.vapier@gentoo.org> In-Reply-To: <201012141403.04352.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012141912.00225.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00258.txt.bz2 On Tuesday 14 December 2010 19:03:02, Mike Frysinger wrote: > On Tuesday, December 14, 2010 13:50:27 Pedro Alves wrote: > > On Tuesday 14 December 2010 18:33:09, Mike Frysinger wrote: > > > ok, some of the (long) casts are necessary. specifically, the ones who > > > have a type of "unsigned_word" as those depend on the target bitness > > > (which could be 16, 32, or 64). > > > > long is 32-bit on Win64. > > so what you're saying is that all the sim code that casts unsigned_word to a > long is broken and not just the code in my patch. sounds like a bigger > problem that should be fixed independently and by someone who is interested in > testing on systems dumb enough to do LLP64. No, I just said "long is 32-bit on Win64". I just noticed src/README-HACKING: C Language Assumptions ====================== The programmer may assume that the simulator is being built using an ANSI C compiler that supports a 64 bit data type. Consequently: o prototypes can be used (although using PARAMS() and K&R declarations wouldn't go astray). o If sim-types.h is included, the two types signed64 and unsigned64 are available. o The type `unsigned' is valid. However, the user should be aware of the following: o GCC's `LL' is NOT acceptable. Microsoft-C doesn't reconize it. o MSC's `i64' is NOT acceptable. GCC doesn't reconize it. o GCC's `long long' MSC's `_int64' can NOT be used to define 64 bit integer data types. o An empty array (eg int a[0]) is not valid. but if the sim is already not following its own rules, let's leave it. For GDB code proper, long would be unacceptible. -- Pedro Alves