Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, Stephen.Kilbane@analog.com,
	Stuart.Henderson@analog.com, David.Gibson@analog.com
Subject: Re: [PATCH] sim: add --map-info option
Date: Wed, 15 Dec 2010 04:54:00 -0000	[thread overview]
Message-ID: <20101215045407.GW2596@adacore.com> (raw)
In-Reply-To: <201012141016.23030.vapier@gentoo.org>

> > Wouldn't it make sense to hoist the assignment to memory out of
> > the for initial assignment? It's never changed during the loop...
> 
> i dont understand ... isnt this the whole purpose of the first clause
> of the for statement ?  initializing things once that dont change
> inside of the loop.  

The code works, and I'm fine if you really want to keep it that way.
But you said "initializing things once that dont change inside of the
loop" and that is not true.  You would typically initialize the
variables used in the looping condition, and these variables change
at each iteration.

But that's beside the point, and I don't think there is anything in
the C language that says what should should do, or should not do.  All
I am saying is that you are doing something unusual: You are initializing
in that clause a variable that is never changed during the loop, nor
referenced in the other two clauses of your for statement. If I was
maintaining the code, I would find it much clearer to initialize
the variable before the loop, and then write a typical "for (...)"
statement.

-- 
Joel


  parent reply	other threads:[~2010-12-15  4:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 16:15 Mike Frysinger
2010-12-14  7:36 ` Joel Brobecker
2010-12-14 15:17   ` Mike Frysinger
2010-12-14 18:34     ` Mike Frysinger
2010-12-14 18:50       ` Pedro Alves
2010-12-14 19:03         ` Mike Frysinger
2010-12-14 19:12           ` Pedro Alves
2010-12-14 19:30             ` Mike Frysinger
2010-12-15  4:54     ` Joel Brobecker [this message]
2010-12-15 11:50       ` Mike Frysinger
2010-12-14 18:37 ` [PATCH v2] " Mike Frysinger
2010-12-15  5:02   ` Joel Brobecker
2010-12-15 11:21     ` Mike Frysinger
2010-12-15 11:48       ` Joel Brobecker
2010-12-15 12:02         ` [toolchain-devel] " Mike Frysinger
2010-12-15 13:16           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101215045407.GW2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=David.Gibson@analog.com \
    --cc=Stephen.Kilbane@analog.com \
    --cc=Stuart.Henderson@analog.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox