From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19542 invoked by alias); 15 Dec 2010 05:02:57 -0000 Received: (qmail 19534 invoked by uid 22791); 15 Dec 2010 05:02:56 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 05:02:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C13FA2BAC02; Wed, 15 Dec 2010 00:02:39 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TauVZ2vzfcqE; Wed, 15 Dec 2010 00:02:39 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 554A02BAB5A; Wed, 15 Dec 2010 00:02:39 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 27CD5145B58; Wed, 15 Dec 2010 06:02:26 +0100 (CET) Date: Wed, 15 Dec 2010 05:02:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH v2] sim: add --map-info option Message-ID: <20101215050226.GX2596@adacore.com> References: <1291219863-18458-1-git-send-email-vapier@gentoo.org> <1292351771-16396-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1292351771-16396-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00277.txt.bz2 > 2010-12-14 Mike Frysinger > > * sim-memopt.c (OPTION_MAP_INFO): Define. > (memory_options): Handle --map-info. > (memory_option_handler): Handle OPTION_MAP_INFO. > --- > v2 > - convert to map_to_str > - drop long casts where unnecessary This looks OK to me. If I read your discussion with Pedro correctly, he's OK too, so OK to commit. One last request: Can you send a patch adding a note in the gdb/NEWS file? Thank you, -- Joel