[rfa] break-entry.exp: suppress test if remote target

[rfa] break-entry.exp: suppress test if remote target

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

This test doesn't work on remote targets (gdbserver), because it sets a 
breakpoint at _start, which is also the current pc.  We never hit a 
breakpoint at the current pc when we continue.


[-- Attachment #2: break-entry.txt --]
[-- Type: text/plain, Size: 671 bytes --]

2010-12-07  Michael Snyder  <msnyder@vmware.com>

	* gdb.base/break-entry.exp: Skip test if remote target.

Index: break-entry.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-entry.exp,v
retrieving revision 1.1
diff -u -p -r1.1 break-entry.exp
--- break-entry.exp	4 Apr 2010 22:12:14 -0000	1.1
+++ break-entry.exp	7 Dec 2010 19:34:26 -0000
@@ -21,6 +21,10 @@ if { [prepare_for_testing ${testfile}.ex
     return -1
 }
 
+if { [target_info exists use_gdb_stub] || [target_info exists gdb_protocol]} then {
+    return -1
+}
+
 set test "info files"
 set entry ""
 gdb_test_multiple $test $test {

Re: [rfa] break-entry.exp: suppress test if remote target

[Jan Kratochvil]

On Tue, 07 Dec 2010 20:35:57 +0100, Michael Snyder wrote:
> This test doesn't work on remote targets (gdbserver), because it
> sets a breakpoint at _start, which is also the current pc.  We never
> hit a breakpoint at the current pc when we continue.

Your patch is out of sync with HEAD so you may not need this patch:

commit 787ced139be0421e8c5e0fbfe7ff5429d8b67601
Author: Nathan Froyd <froydnj@codesourcery.com>
Date:   Fri Nov 12 21:47:47 2010 +0000

    gdb/testsuite/
        * gdb.base/break-entry.exp: Skip if using a stub.

As this testcase uses `-static' it is probably OK.  (Otherwise it would
probably make sense to stop at _start, which is only after ld.so gets
executed.)


Thanks,
Jan


> 2010-12-07  Michael Snyder  <msnyder@vmware.com>
> 
> 	* gdb.base/break-entry.exp: Skip test if remote target.
> 
> Index: break-entry.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-entry.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 break-entry.exp
> --- break-entry.exp	4 Apr 2010 22:12:14 -0000	1.1
> +++ break-entry.exp	7 Dec 2010 19:34:26 -0000
> @@ -21,6 +21,10 @@ if { [prepare_for_testing ${testfile}.ex
>      return -1
>  }
>  
> +if { [target_info exists use_gdb_stub] || [target_info exists gdb_protocol]} then {
> +    return -1
> +}
> +
>  set test "info files"
>  set entry ""
>  gdb_test_multiple $test $test {

Re: [rfa] break-entry.exp: suppress test if remote target

[Michael Snyder]

Jan Kratochvil wrote:
> On Tue, 07 Dec 2010 20:35:57 +0100, Michael Snyder wrote:
>> This test doesn't work on remote targets (gdbserver), because it
>> sets a breakpoint at _start, which is also the current pc.  We never
>> hit a breakpoint at the current pc when we continue.
> 
> Your patch is out of sync with HEAD so you may not need this patch:
> 
> commit 787ced139be0421e8c5e0fbfe7ff5429d8b67601
> Author: Nathan Froyd <froydnj@codesourcery.com>
> Date:   Fri Nov 12 21:47:47 2010 +0000
> 
>     gdb/testsuite/
>         * gdb.base/break-entry.exp: Skip if using a stub.

I see.  I was on the 7.2 branch.
Thanks.