From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27441 invoked by alias); 9 Dec 2010 21:41:31 -0000 Received: (qmail 27143 invoked by uid 22791); 9 Dec 2010 21:41:28 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Dec 2010 21:40:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB9LedAe003593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 9 Dec 2010 16:40:39 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB9LeZnV020731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 9 Dec 2010 16:40:38 -0500 Received: from host0.dyn.jankratochvil.net (host0.dyn.jankratochvil.net [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oB9LeY2f013649; Thu, 9 Dec 2010 22:40:34 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oB9LeXZn013644; Thu, 9 Dec 2010 22:40:33 +0100 Date: Thu, 09 Dec 2010 21:41:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [rfa] break-entry.exp: suppress test if remote target Message-ID: <20101209214033.GA13419@host0.dyn.jankratochvil.net> References: <4CFE8C9D.2060108@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CFE8C9D.2060108@vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00120.txt.bz2 On Tue, 07 Dec 2010 20:35:57 +0100, Michael Snyder wrote: > This test doesn't work on remote targets (gdbserver), because it > sets a breakpoint at _start, which is also the current pc. We never > hit a breakpoint at the current pc when we continue. Your patch is out of sync with HEAD so you may not need this patch: commit 787ced139be0421e8c5e0fbfe7ff5429d8b67601 Author: Nathan Froyd Date: Fri Nov 12 21:47:47 2010 +0000 gdb/testsuite/ * gdb.base/break-entry.exp: Skip if using a stub. As this testcase uses `-static' it is probably OK. (Otherwise it would probably make sense to stop at _start, which is only after ld.so gets executed.) Thanks, Jan > 2010-12-07 Michael Snyder > > * gdb.base/break-entry.exp: Skip test if remote target. > > Index: break-entry.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-entry.exp,v > retrieving revision 1.1 > diff -u -p -r1.1 break-entry.exp > --- break-entry.exp 4 Apr 2010 22:12:14 -0000 1.1 > +++ break-entry.exp 7 Dec 2010 19:34:26 -0000 > @@ -21,6 +21,10 @@ if { [prepare_for_testing ${testfile}.ex > return -1 > } > > +if { [target_info exists use_gdb_stub] || [target_info exists gdb_protocol]} then { > + return -1 > +} > + > set test "info files" > set entry "" > gdb_test_multiple $test $test {