From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [rfa] break-entry.exp: suppress test if remote target
Date: Thu, 09 Dec 2010 21:41:00 -0000 [thread overview]
Message-ID: <20101209214033.GA13419@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4CFE8C9D.2060108@vmware.com>
On Tue, 07 Dec 2010 20:35:57 +0100, Michael Snyder wrote:
> This test doesn't work on remote targets (gdbserver), because it
> sets a breakpoint at _start, which is also the current pc. We never
> hit a breakpoint at the current pc when we continue.
Your patch is out of sync with HEAD so you may not need this patch:
commit 787ced139be0421e8c5e0fbfe7ff5429d8b67601
Author: Nathan Froyd <froydnj@codesourcery.com>
Date: Fri Nov 12 21:47:47 2010 +0000
gdb/testsuite/
* gdb.base/break-entry.exp: Skip if using a stub.
As this testcase uses `-static' it is probably OK. (Otherwise it would
probably make sense to stop at _start, which is only after ld.so gets
executed.)
Thanks,
Jan
> 2010-12-07 Michael Snyder <msnyder@vmware.com>
>
> * gdb.base/break-entry.exp: Skip test if remote target.
>
> Index: break-entry.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break-entry.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 break-entry.exp
> --- break-entry.exp 4 Apr 2010 22:12:14 -0000 1.1
> +++ break-entry.exp 7 Dec 2010 19:34:26 -0000
> @@ -21,6 +21,10 @@ if { [prepare_for_testing ${testfile}.ex
> return -1
> }
>
> +if { [target_info exists use_gdb_stub] || [target_info exists gdb_protocol]} then {
> + return -1
> +}
> +
> set test "info files"
> set entry ""
> gdb_test_multiple $test $test {
next prev parent reply other threads:[~2010-12-09 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 19:36 Michael Snyder
2010-12-09 21:41 ` Jan Kratochvil [this message]
2010-12-09 22:13 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209214033.GA13419@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox