* [RFA] DESTDIR & "//"
@ 2010-11-19 23:22 Keith Seitz
2010-11-19 23:34 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2010-11-19 23:22 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
Hi,
I believe the install targets in data-directory/Makefile.in are misusing
the DESTDIR option. They currently do "$(DESTDIR)/$(FOO_DIR)". I believe
this should simply be "$(DESTDIR)$(FOO_DIR)".
While trying to install into "//foo" isn't a big deal on *nix, it is
quite a different story on MinGW, which attempts to look for a server
named foo.
Ok?
ChangeLog
2010-11-19 Keith Seitz <keiths@redhat.com>
* data-directory/Makefile.in (SYSCALLS_INSTALL_DIR):
Remove extraneous '/' after $(DESTDIR).
(PYTHON_INSTALL_DIR): Likewise.
[-- Attachment #2: DESTDIR-double-slash.patch --]
[-- Type: text/plain, Size: 925 bytes --]
Index: data-directory/Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/data-directory/Makefile.in,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile.in
--- data-directory/Makefile.in 2 Nov 2010 22:44:12 -0000 1.5
+++ data-directory/Makefile.in 19 Nov 2010 22:55:04 -0000
@@ -41,7 +41,7 @@ INSTALL_DIR = $(SHELL) $(srcdir)/../../m
GDB_DATADIR = @GDB_DATADIR@
SYSCALLS_DIR = syscalls
-SYSCALLS_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(SYSCALLS_DIR)
+SYSCALLS_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(SYSCALLS_DIR)
SYSCALLS_FILES = \
gdb-syscalls.dtd \
ppc-linux.xml ppc64-linux.xml \
@@ -49,7 +49,7 @@ SYSCALLS_FILES = \
sparc-linux.xml sparc64-linux.xml
PYTHON_DIR = python
-PYTHON_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(PYTHON_DIR)
+PYTHON_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(PYTHON_DIR)
PYTHON_FILES = \
gdb/__init__.py \
gdb/types.py \
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] DESTDIR & "//"
2010-11-19 23:22 [RFA] DESTDIR & "//" Keith Seitz
@ 2010-11-19 23:34 ` Daniel Jacobowitz
2010-11-19 23:37 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2010-11-19 23:34 UTC (permalink / raw)
To: Keith Seitz; +Cc: gdb-patches
On Fri, Nov 19, 2010 at 03:18:15PM -0800, Keith Seitz wrote:
> Hi,
>
> I believe the install targets in data-directory/Makefile.in are
> misusing the DESTDIR option. They currently do
> "$(DESTDIR)/$(FOO_DIR)". I believe this should simply be
> "$(DESTDIR)$(FOO_DIR)".
>
> While trying to install into "//foo" isn't a big deal on *nix, it is
> quite a different story on MinGW, which attempts to look for a server
> named foo.
>
> Ok?
OK.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] DESTDIR & "//"
2010-11-19 23:34 ` Daniel Jacobowitz
@ 2010-11-19 23:37 ` Keith Seitz
0 siblings, 0 replies; 3+ messages in thread
From: Keith Seitz @ 2010-11-19 23:37 UTC (permalink / raw)
To: gdb-patches
On 11/19/2010 03:34 PM, Daniel Jacobowitz wrote:
> On Fri, Nov 19, 2010 at 03:18:15PM -0800, Keith Seitz wrote:
>>
>> Ok?
>
> OK.
Committed. Thank you!
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-19 23:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-19 23:22 [RFA] DESTDIR & "//" Keith Seitz
2010-11-19 23:34 ` Daniel Jacobowitz
2010-11-19 23:37 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox