[RFA] DESTDIR & "//"

Keith Seitz
2010-11-19T23:22:05Z

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

Hi,

I believe the install targets in data-directory/Makefile.in are misusing
the DESTDIR option. They currently do "$(DESTDIR)/$(FOO_DIR)". I believe
this should simply be "$(DESTDIR)$(FOO_DIR)".

While trying to install into "//foo" isn't a big deal on *nix, it is
quite a different story on MinGW, which attempts to look for a server
named foo.

Ok?

ChangeLog
2010-11-19 Keith Seitz <keiths@redhat.com>

* data-directory/Makefile.in (SYSCALLS_INSTALL_DIR):
Remove extraneous '/' after $(DESTDIR).
(PYTHON_INSTALL_DIR): Likewise.

[-- Attachment #2: DESTDIR-double-slash.patch --]
[-- Type: text/plain, Size: 925 bytes --]

Index: data-directory/Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/data-directory/Makefile.in,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile.in
--- data-directory/Makefile.in 2 Nov 2010 22:44:12 -0000 1.5
+++ data-directory/Makefile.in 19 Nov 2010 22:55:04 -0000
@@ -41,7 +41,7 @@ INSTALL_DIR = $(SHELL) $(srcdir)/../../m
GDB_DATADIR = @GDB_DATADIR@

SYSCALLS_DIR = syscalls
-SYSCALLS_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(SYSCALLS_DIR)
+SYSCALLS_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(SYSCALLS_DIR)
SYSCALLS_FILES = \
gdb-syscalls.dtd \
ppc-linux.xml ppc64-linux.xml \
@@ -49,7 +49,7 @@ SYSCALLS_FILES = \
sparc-linux.xml sparc64-linux.xml

PYTHON_DIR = python
-PYTHON_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(PYTHON_DIR)
+PYTHON_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(PYTHON_DIR)
PYTHON_FILES = \
gdb/__init__.py \
gdb/types.py \