From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26430 invoked by alias); 19 Nov 2010 23:22:05 -0000 Received: (qmail 26422 invoked by uid 22791); 19 Nov 2010 23:22:03 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SUBJ_ALL_CAPS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 23:21:59 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAJNLvcC021841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Nov 2010 18:21:57 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oAJNLtvp019056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 19 Nov 2010 18:21:57 -0500 Message-ID: <4CE705B7.6010604@redhat.com> Date: Fri, 19 Nov 2010 23:22:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [RFA] DESTDIR & "//" Content-Type: multipart/mixed; boundary="------------090707090408070109020802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00277.txt.bz2 This is a multi-part message in MIME format. --------------090707090408070109020802 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 542 Hi, I believe the install targets in data-directory/Makefile.in are misusing the DESTDIR option. They currently do "$(DESTDIR)/$(FOO_DIR)". I believe this should simply be "$(DESTDIR)$(FOO_DIR)". While trying to install into "//foo" isn't a big deal on *nix, it is quite a different story on MinGW, which attempts to look for a server named foo. Ok? ChangeLog 2010-11-19 Keith Seitz * data-directory/Makefile.in (SYSCALLS_INSTALL_DIR): Remove extraneous '/' after $(DESTDIR). (PYTHON_INSTALL_DIR): Likewise. --------------090707090408070109020802 Content-Type: text/plain; name="DESTDIR-double-slash.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="DESTDIR-double-slash.patch" Content-length: 925 Index: data-directory/Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/data-directory/Makefile.in,v retrieving revision 1.5 diff -u -p -r1.5 Makefile.in --- data-directory/Makefile.in 2 Nov 2010 22:44:12 -0000 1.5 +++ data-directory/Makefile.in 19 Nov 2010 22:55:04 -0000 @@ -41,7 +41,7 @@ INSTALL_DIR = $(SHELL) $(srcdir)/../../m GDB_DATADIR = @GDB_DATADIR@ SYSCALLS_DIR = syscalls -SYSCALLS_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(SYSCALLS_DIR) +SYSCALLS_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(SYSCALLS_DIR) SYSCALLS_FILES = \ gdb-syscalls.dtd \ ppc-linux.xml ppc64-linux.xml \ @@ -49,7 +49,7 @@ SYSCALLS_FILES = \ sparc-linux.xml sparc64-linux.xml PYTHON_DIR = python -PYTHON_INSTALL_DIR = $(DESTDIR)/$(GDB_DATADIR)/$(PYTHON_DIR) +PYTHON_INSTALL_DIR = $(DESTDIR)$(GDB_DATADIR)/$(PYTHON_DIR) PYTHON_FILES = \ gdb/__init__.py \ gdb/types.py \ --------------090707090408070109020802--