From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 1/5] New patches to support --enable-targets=all for mingw64
Date: Mon, 13 Sep 2010 18:11:00 -0000 [thread overview]
Message-ID: <20100913175106.GA3845@adacore.com> (raw)
In-Reply-To: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr>
(the issues you have encountered are very familiar to me, since I had
the same problem when I ported the native debugger to 64bit windows).
> 1) Replace remaining #include <winsock.h> by #inlcude <winsock2.h>
> in remote-m32r-sdi.c and m32r-rom.c
>
> I apologize to the person that already submitted a similar
> change, but I was unable to find it again.
> I vaguely remember that we already discussed this once, but there
> are still two <winsock.h> inlcudes in gdb HEAD.
[...]
> 2010-09-10 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * m32r-rom.c: Replace winsock.h with winsock2.h header.
> * remote-m32r-sdi.c: Replace winsock.h by winsock2.h.
I don't know much about Windows systems, but since no one reviewed
the patch, I did some research. I believe the patch is correct, since
we are linking gdb and gdbserver against ws2_32.lib, so the correct
include is winsock2.h (winsock.h is for wsock32.lib).
http://cboard.cprogramming.com/networking-device-communication/71596-winsock-vs-winsock2.html
So this is OK.
Thank you,
--
Joel
next prev parent reply other threads:[~2010-09-13 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 14:06 Pierre Muller
2010-09-13 18:11 ` Joel Brobecker [this message]
2010-09-14 15:04 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100913175106.GA3845@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox