Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA 1/5] New patches to support --enable-targets=all for mingw64
Date: Fri, 10 Sep 2010 14:06:00 -0000	[thread overview]
Message-ID: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr> (raw)

  I tried to compile GDB with
--enable-targets=all for x86_64-w64-mingw32
target.
  As 'long' type is 4-byte while pointer type is 8-byte,
this target is quite sensitive to so 'dirty' code
lying around like casting 'long' or 'unsigned long' to pointers...

  I had to fix several sources to be able to 
successfully compile GDB with those configuration options.

1) Replace remaining #include <winsock.h> by #inlcude <winsock2.h>
in remote-m32r-sdi.c and m32r-rom.c

  I apologize to the person that already submitted a similar 
change, but I was unable to find it again. 
  I vaguely remember that we already discussed this once, but there
are still two <winsock.h> inlcudes in gdb HEAD.

  The patch below fixes this.
  
Pierre Muller
Pascal language support maintainer for GDB


2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>

	* m32r-rom.c: Replace winsock.h with winsock2.h header.
	* remote-m32r-sdi.c: Replace winsock.h by winsock2.h.

Index: src/gdb/m32r-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/m32r-rom.c,v
retrieving revision 1.40
diff -u -p -r1.40 m32r-rom.c
--- src/gdb/m32r-rom.c	1 Jan 2010 07:31:37 -0000	1.40
+++ src/gdb/m32r-rom.c	9 Sep 2010 16:39:58 -0000
@@ -45,7 +45,7 @@
  * All this stuff just to get my host computer's IP address!
  */
 #ifdef __MINGW32__
-#include <winsock.h>
+#include <winsock2.h>
 #else
 #include <sys/types.h>
 #include <netdb.h>		/* for hostent */
Index: src/gdb/remote-m32r-sdi.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-m32r-sdi.c,v
retrieving revision 1.52
diff -u -p -r1.52 remote-m32r-sdi.c
--- src/gdb/remote-m32r-sdi.c	6 Sep 2010 13:59:02 -0000	1.52
+++ src/gdb/remote-m32r-sdi.c	9 Sep 2010 16:39:59 -0000
@@ -32,7 +32,7 @@
 #include <ctype.h>
 #include <signal.h>
 #ifdef __MINGW32__
-#include <winsock.h>
+#include <winsock2.h>
 #else
 #include <netinet/in.h>
 #endif


             reply	other threads:[~2010-09-10 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 14:06 Pierre Muller [this message]
2010-09-13 18:11 ` Joel Brobecker
2010-09-14 15:04   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr' \
    --to=pierre.muller@ics-cnrs.unistra.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox