RE: [RFA 1/5] New patches to support --enable-targets=all for mingw64

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> Objet : Re: [RFA 1/5] New patches to support --enable-targets=all for
> mingw64
> 
> (the issues you have encountered are very familiar to me, since I had
> the same problem when I ported the native debugger to 64bit windows).
> 
> > 1) Replace remaining #include <winsock.h> by #inlcude <winsock2.h>
> > in remote-m32r-sdi.c and m32r-rom.c
> >
> >   I apologize to the person that already submitted a similar
> > change, but I was unable to find it again.
> >   I vaguely remember that we already discussed this once, but there
> > are still two <winsock.h> inlcudes in gdb HEAD.
> [...]
> > 2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> > 	* m32r-rom.c: Replace winsock.h with winsock2.h header.
> > 	* remote-m32r-sdi.c: Replace winsock.h by winsock2.h.
> 
> I don't know much about Windows systems, but since no one reviewed
> the patch, I did some research.  I believe the patch is correct, since
> we are linking gdb and gdbserver against ws2_32.lib, so the correct
> include is winsock2.h (winsock.h is for wsock32.lib).
> 
> http://cboard.cprogramming.com/networking-device-communication/71596-
> winsock-vs-winsock2.html
> 
> So this is OK.

  Thanks for the approval,
patch committed.


Pierre Muller
Pascal language support maintainer for GDB