From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32508 invoked by alias); 14 Sep 2010 08:02:19 -0000 Received: (qmail 32499 invoked by uid 22791); 14 Sep 2010 08:02:18 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Sep 2010 08:02:14 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o8E81wWD010584 ; Tue, 14 Sep 2010 10:01:58 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms7.u-strasbg.fr [IPv6:2001:660:2402:d::16]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8E81voG014900 ; Tue, 14 Sep 2010 10:01:57 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8E81uR4062985 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 14 Sep 2010 10:01:57 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr> <20100913175106.GA3845@adacore.com> In-Reply-To: <20100913175106.GA3845@adacore.com> Subject: RE: [RFA 1/5] New patches to support --enable-targets=all for mingw64 Date: Tue, 14 Sep 2010 15:04:00 -0000 Message-ID: <000f01cb53e3$1bb8ab40$532a01c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00263.txt.bz2 > Objet=A0: Re: [RFA 1/5] New patches to support --enable-targets=3Dall for > mingw64 >=20 > (the issues you have encountered are very familiar to me, since I had > the same problem when I ported the native debugger to 64bit windows). >=20 > > 1) Replace remaining #include by #inlcude > > in remote-m32r-sdi.c and m32r-rom.c > > > > I apologize to the person that already submitted a similar > > change, but I was unable to find it again. > > I vaguely remember that we already discussed this once, but there > > are still two inlcudes in gdb HEAD. > [...] > > 2010-09-10 Pierre Muller > > > > * m32r-rom.c: Replace winsock.h with winsock2.h header. > > * remote-m32r-sdi.c: Replace winsock.h by winsock2.h. >=20 > I don't know much about Windows systems, but since no one reviewed > the patch, I did some research. I believe the patch is correct, since > we are linking gdb and gdbserver against ws2_32.lib, so the correct > include is winsock2.h (winsock.h is for wsock32.lib). >=20 > http://cboard.cprogramming.com/networking-device-communication/71596- > winsock-vs-winsock2.html >=20 > So this is OK. Thanks for the approval, patch committed. Pierre Muller Pascal language support maintainer for GDB