From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6403 invoked by alias); 13 Sep 2010 17:51:16 -0000 Received: (qmail 6395 invoked by uid 22791); 13 Sep 2010 17:51:16 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Sep 2010 17:51:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5C6DB2BABFE; Mon, 13 Sep 2010 13:51:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8AGgzJ7osRjK; Mon, 13 Sep 2010 13:51:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 276D22BABFD; Mon, 13 Sep 2010 13:51:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3662EF599F; Mon, 13 Sep 2010 13:51:06 -0400 (EDT) Date: Mon, 13 Sep 2010 18:11:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/5] New patches to support --enable-targets=all for mingw64 Message-ID: <20100913175106.GA3845@adacore.com> References: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003601cb50f0$23ef75a0$6bce60e0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00250.txt.bz2 (the issues you have encountered are very familiar to me, since I had the same problem when I ported the native debugger to 64bit windows). > 1) Replace remaining #include by #inlcude > in remote-m32r-sdi.c and m32r-rom.c > > I apologize to the person that already submitted a similar > change, but I was unable to find it again. > I vaguely remember that we already discussed this once, but there > are still two inlcudes in gdb HEAD. [...] > 2010-09-10 Pierre Muller > > * m32r-rom.c: Replace winsock.h with winsock2.h header. > * remote-m32r-sdi.c: Replace winsock.h by winsock2.h. I don't know much about Windows systems, but since no one reviewed the patch, I did some research. I believe the patch is correct, since we are linking gdb and gdbserver against ws2_32.lib, so the correct include is winsock2.h (winsock.h is for wsock32.lib). http://cboard.cprogramming.com/networking-device-communication/71596-winsock-vs-winsock2.html So this is OK. Thank you, -- Joel