Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
	gdb-patches@sourceware.org
Subject: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute
Date: Mon, 17 May 2010 17:34:00 -0000	[thread overview]
Message-ID: <20100517172758.GJ2805@adacore.com> (raw)
In-Reply-To: <m34oibvhgh.fsf@fleche.redhat.com>

> Pierre>   Should zero be considered as FALSE and
> Pierre> thus the should say that this parameter is NOT a variable parameter,
> Pierre> or does the simple presence of this attribute condfirm
> Pierre> this it is a variable parameter, no matter the value of the flag.
> Pierre> I took the first approach here, but have the impression
> Pierre> that it is not always the case inside dwarf2read.c code.
> 
> I think you made the correct choice.

FWIW: I also double-checked the DWARF3 standard, and it says that the
value of this attribute is a flag, and following the hyperlinks in
the PDF, one gets to:

    flag
        A flag is represented as a single byte of data (DW_FORM_flag).
        If the flag has value zero, it indicates the absence of the
        attribute. If the flag has a non-zero value, it indicates the
        presence of the attribute.

-- 
Joel


  reply	other threads:[~2010-05-17 17:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8830.7035308846$1273670829@news.gmane.org>
2010-05-13 17:51 ` Tom Tromey
2010-05-17 17:34   ` Joel Brobecker [this message]
2010-05-17 17:34     ` Pierre Muller
2010-05-17 18:54       ` Joel Brobecker
2010-05-17 21:48         ` Pierre Muller
     [not found]         ` <44296.7587885962$1274132782@news.gmane.org>
2010-05-19 19:43           ` Tom Tromey
2010-05-19 21:45             ` Pierre Muller
     [not found]             ` <28559.2589797036$1274302480@news.gmane.org>
2010-05-19 22:34               ` Tom Tromey
2010-05-19 23:34                 ` [RFA-v2] " Pierre Muller
     [not found]                 ` <27418.1569614031$1274308493@news.gmane.org>
2010-05-21 17:44                   ` Tom Tromey
2010-05-21 20:50                     ` Pierre Muller
2010-11-04  5:32                       ` [new testcase] Regression 7.1->7.2 for iFort [Re: [RFA-v2] dwarf debug format: Support DW_AT_variable_parameter attribute] Jan Kratochvil
2010-11-04  8:47                         ` [Core] " Pierre Free Pascal
2010-11-04 18:01                           ` Joel Brobecker
2010-11-05  8:04                             ` Pierre Free Pascal
2011-09-01  7:20                           ` Jan Kratochvil
2010-05-12 13:27 [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517172758.GJ2805@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox